chore: upgrade to api 1.1.3 #29
Conversation
|
|
✅ Deploy Preview for webcontainer-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -131,7 +131,7 @@ async function bootWebContainer(terminal: import('xterm').Terminal) { | |||
|
|
|||
| terminal.write('Booting WebContainer...'); | |||
|
|
|||
| webcontainer = WebContainer.boot(); | |||
| webcontainer = WebContainer.boot({ workdirName: 'demo' }); | |||
There was a problem hiding this comment.
Could you tell me more about this? 👀
Also, should we update docs?
There was a problem hiding this comment.
Right now, the terminal prompt in our site reads ~/httpswebcontainersio-wyqd. With this, it'll be ~/demo instead (but it's open to bikeshed).
Re: updating the docs: it's a minor cosmetic change, I'm not sure where I would squeeze it.
There was a problem hiding this comment.
oh I love it.
I'll fit it in as a tip somewhere :)
| @@ -16,7 +17,7 @@ | |||
| "@codemirror/theme-one-dark": "^6.1.0", | |||
| "@codemirror/view": "^6.8.0", | |||
| "@lezer/highlight": "^1.1.3", | |||
| "@webcontainer/api": "^1.0.0-alpha.3", | |||
| "@webcontainer/api": "^1.1.3", | |||
There was a problem hiding this comment.
This might be an obvious answer but you’re mentioning “1.1.1” in the PR but throughout the files here I see “1.1.3” and I’m wondering if the discrepancy is meaningful in any way?
(This is not meant as a nit pick - in a broader context, I’m getting familiar with our versioning)
There was a problem hiding this comment.
Yeah, my intent was to upgrade to 1.1.1, but it seems that this is the right version we should be picking instead. I'll update the PR title.
Dogfood our most recent version.