changes for v1.1.0 #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for webcontainer-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jrvidal
commented
Mar 30, 2023
| @@ -131,7 +131,7 @@ async function bootWebContainer(terminal: import('xterm').Terminal) { | |||
|
|
|||
| terminal.write('Booting WebContainer...'); | |||
|
|
|||
| webcontainer = WebContainer.boot(); | |||
| webcontainer = WebContainer.boot({ workdirName: 'demo' }); | |||
There was a problem hiding this comment.
⭐ This changes the folder name visible in the terminal from ~/webcontainersio-98a7w9 or whatever to simply ~/demo.
(EDIT: nevermind, had to revert)
jrvidal
commented
Mar 30, 2023
Comment on lines
+17
to
+19
| * The name of the working directory can be specified through `BootOptions#workdirName`. | ||
| * The default value of the `PATH` environment variable is exposed in `WebContainer#path`. | ||
| * The full path of the working directory is exposed in `WebContainer#workdir`. |
There was a problem hiding this comment.
|
Oh, lol, v1.1.0 broke some stuff, so we can't dogfood just yet. I'll revert for now. |
| @@ -12,7 +12,7 @@ head: | |||
|
|
|||
| This guide provides an overview on how to configure COOP/COEP headers, including hosting platform configuration. | |||
|
|
|||
| WebContainers require that your page, even in development, be served with these two headers: | |||
| WebContainers require that your page, even in development, is served with these two headers: | |||
Co-authored-by: Sylwia Vargas <[email protected]>
sylwiavargas
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs for the new 1.1.0 version. What to do about API reference changes is TBD. I want to upgrade the docs themselves to use 1.1.0, but we might need to ship a fix before.