Skip to content

[Merged by Bors] - Fix PVC-related tests on managed k8s #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 33 commits into from

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Jun 27, 2022

Description

Fix PVC-related tests running on managed kubernetes.

PVCs defined with standard storage can only have an access mode of ReadWriteOnce and thus cannot be mounted on multiple nodes. For the purposes of testing, the node selector is used to ensure that components of a test all run on the same node (which is node 1, due to current resource bottlenecks on some managed k8s).

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@adwk67 adwk67 self-assigned this Jun 27, 2022
@adwk67 adwk67 marked this pull request as ready for review June 28, 2022 13:20
@adwk67 adwk67 requested a review from a team June 28, 2022 13:20
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adwk67
Copy link
Member Author

adwk67 commented Jun 28, 2022

bors merge

bors bot pushed a commit that referenced this pull request Jun 28, 2022
# Description

Fix PVC-related tests running on managed kubernetes. 

PVCs defined with standard storage can only have an access mode of ReadWriteOnce and thus cannot be mounted on multiple nodes. For the purposes of testing, the node selector is used to ensure that components of a test all run on the same node (which is node 1, due to current resource bottlenecks on some managed k8s).
@bors
Copy link

bors bot commented Jun 28, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix PVC-related tests on managed k8s [Merged by Bors] - Fix PVC-related tests on managed k8s Jun 28, 2022
@bors bors bot closed this Jun 28, 2022
@bors bors bot deleted the pvc-tests branch June 28, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants