-
-
Notifications
You must be signed in to change notification settings - Fork 3
[Merged by Bors] - Add pull policy #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image pull policy should also be added to the driver and executor pod templates.
Isn't it the same image, though? The Job pod pulls the image (or not), and then this image is the same one used for the driver/executors (the pull policy only applies to the spark image, intentionally). |
Yes, but the Job starts one pod on one node, and in a production cluster there will be more nodes for running the actual spark cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests still work and there is one small thing but it LGTM otherwise.
bors merge |
# Description Added two optional fields to the custom resource to govern pull policy and secrets to be used when accessing images. Closes #69.
Pull request successfully merged into main. Build succeeded: |
Description
Added two optional fields to the custom resource to govern pull policy and secrets to be used when accessing images.
Closes #69.
Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information