Skip to content

[Merged by Bors] - Add pull policy #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - Add pull policy #75

wants to merge 14 commits into from

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented May 31, 2022

Description

Added two optional fields to the custom resource to govern pull policy and secrets to be used when accessing images.
Closes #69.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@adwk67 adwk67 marked this pull request as ready for review May 31, 2022 16:17
@adwk67 adwk67 requested review from razvan and fhennig May 31, 2022 16:17
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image pull policy should also be added to the driver and executor pod templates.

@adwk67
Copy link
Member Author

adwk67 commented Jun 2, 2022

Isn't it the same image, though? The Job pod pulls the image (or not), and then this image is the same one used for the driver/executors (the pull policy only applies to the spark image, intentionally).

@razvan
Copy link
Member

razvan commented Jun 2, 2022

Isn't it the same image, though? The Job pod pulls the image (or not), and then this image is the same one used for the driver/executors (the pull policy only applies to the spark image, intentionally).

Yes, but the Job starts one pod on one node, and in a production cluster there will be more nodes for running the actual spark cluster.

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests still work and there is one small thing but it LGTM otherwise.

@adwk67
Copy link
Member Author

adwk67 commented Jun 3, 2022

bors merge

bors bot pushed a commit that referenced this pull request Jun 3, 2022
# Description

Added two optional fields to the custom resource to govern pull policy and secrets to be used when accessing images.
Closes #69.
@bors
Copy link

bors bot commented Jun 3, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add pull policy [Merged by Bors] - Add pull policy Jun 3, 2022
@bors bors bot closed this Jun 3, 2022
@bors bors bot deleted the add-pull-policy branch June 3, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add imagePullPolicy to SparkApplication CRD
2 participants