Skip to content

feat: Support configuring JVM arguments #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 7, 2025
Merged

feat: Support configuring JVM arguments #532

merged 14 commits into from
Mar 7, 2025

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Mar 4, 2025 •
edited
Loading

Description

Part of stackabletech/issues#584

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@sbernauer sbernauer mentioned this pull request Mar 4, 2025
Closed
@sbernauer sbernauer changed the title Add field to CRD feat: Support configuring JVM arguments Mar 4, 2025
sbernauer
sbernauer commented Mar 4, 2025
View reviewed changes
@sbernauer
Copy link
Member Author

Started https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/14/

@sbernauer sbernauer requested a review from maltesander March 5, 2025 08:06
@sbernauer
Copy link
Member Author

Tests passed

@sbernauer sbernauer removed the request for review from maltesander March 5, 2025 08:06
@sbernauer sbernauer self-assigned this Mar 5, 2025
@sbernauer sbernauer marked this pull request as ready for review March 5, 2025 10:56
@maltesander maltesander self-requested a review March 5, 2025 11:00
maltesander
maltesander reviewed Mar 5, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will test a little tomorrow!

@sbernauer sbernauer requested a review from maltesander March 6, 2025 14:51
maltesander
maltesander previously approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer requested a review from maltesander March 7, 2025 07:49
maltesander
maltesander approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer enabled auto-merge March 7, 2025 07:59
@sbernauer sbernauer added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit b28d8a4 Mar 7, 2025
17 checks passed
@sbernauer sbernauer deleted the feat/jvm-arguments branch March 7, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @maltesander