Skip to content

fix: Use correct label selector for pod-driver-controller #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

sbernauer
Copy link
Member

Fixup of #515

Fixes

2025-01-25T14:55:33.797725Z ERROR stackable_operator::logging::controller: Failed to reconcile object controller.name="pod-driver.spark.stackable.tech" error=tried to reconcile object Pod.v1./pyspark-pi-20250125145500-5ae7fc949df5a93e-driver.kuttl-test-resolved-flounder that was not found in local store

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@sbernauer sbernauer added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit b3fd9ce Jan 27, 2025
17 checks passed
@sbernauer sbernauer deleted the fix/driver-pod-controller-label-selector branch January 27, 2025 12:43
@Techassi
Copy link
Member

Techassi commented Feb 6, 2025

This bug was encountered by a user on Discord (who runs this operator in an production environment). It might be worth to mention this in the release notes for 25.3.

Okay, nevermind. This bug was never part of an released operator as far as I can see.

@sbernauer
Copy link
Member Author

This bug was never part of an released operator as far as I can see.

Exactly, it only existed for 1-2 days in 0.0.0-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants