-
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: run containerdebug in the background #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟢 Tests
The logging test passed when executed as a single:
|
nightkr
reviewed
Dec 19, 2024
I cleaned it up a bit
|
nightkr
previously approved these changes
Dec 19, 2024
Co-authored-by: Natalie Klestrup Röijezon <[email protected]>
nightkr
previously approved these changes
Jan 13, 2025
nightkr
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#527
The
containerdebug
binary is executed in the Spark application pods by evaluating the_STACKABLE_PRE_HOOK
in therun-spark.sh
script. This script is the entrypoint of the Spark product image,Had to reorganize the smoke test in order to fetch debug information while the Spark application is running. Fetching the
containerdebug
output after the job succeeds is not possible because the pods are terminated.Also refactored the container's
command
andargs
properties to be more readable and more in line with other operators.Definition of Done Checklist