[Merged by Bors] - Added s3 section #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 1, 2022
## Description - Added s3 section to the CRD. - credentials and endpoint are written to env vars/config options fixes #37 A test case has been added here: https://github.com/stackabletech/integration-tests/pull/205 and should be reviewed at the same time. Co-authored-by: Felix Hennig <[email protected]> Co-authored-by: Andrew Kenworthy <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #37
A test case has been added here: https://github.com/stackabletech/integration-tests/pull/205 and should be reviewed at the same time.
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information