Skip to content

[Merged by Bors] - RBAC Setup for Spark Driver #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

[Merged by Bors] - RBAC Setup for Spark Driver #39

wants to merge 19 commits into from

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Mar 29, 2022 •
edited by adwk67
Loading

Description

  • Adds a new ClusterRole to the Helm Chart that is used by spark-submit and the driver pod to manage pods & services.
  • Adds code that generates a ServiceAccount and RoleBinding to the role for every SparkApplication. The account is deleted once the application is deleted.

fixes #29

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@stackable-bot
Copy link
Contributor

stackable-bot commented Mar 29, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@fhennig fhennig marked this pull request as ready for review March 30, 2022 13:19
@adwk67
Copy link
Member

adwk67 commented Mar 30, 2022

Tested examples with externally-running operator (+ manually applied clusterrole) and also with helm chart.
LGTM.

@fhennig
Copy link
Contributor Author

fhennig commented Mar 31, 2022

bors merge

@bors
Copy link

bors bot commented Mar 31, 2022

👎 Rejected by too few approved reviews

@adwk67 adwk67 self-requested a review March 31, 2022 07:11
adwk67
adwk67 approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@fhennig
Copy link
Contributor Author

fhennig commented Mar 31, 2022

bors merge

bors bot pushed a commit that referenced this pull request Mar 31, 2022
@razvan @adwk67
RBAC Setup for Spark Driver (#39)
984e5b2 
## Description

- Adds a new ClusterRole to the Helm Chart that is used by spark-submit and the driver pod to manage pods & services.
- Adds code that generates a `ServiceAccount` and `RoleBinding` to the role for every `SparkApplication`. The account is deleted once the application is deleted.

fixes #29 



Co-authored-by: Razvan-Daniel Mihai <[email protected]>
Co-authored-by: Andrew Kenworthy <[email protected]>
@bors
Copy link

bors bot commented Mar 31, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title RBAC Setup for Spark Driver [Merged by Bors] - RBAC Setup for Spark Driver Mar 31, 2022
@bors bors bot closed this Mar 31, 2022
@bors bors bot deleted the rbac-setup branch March 31, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

k8s Role setup + Helm
4 participants
@fhennig @stackable-bot @adwk67 @razvan