Skip to content

docs: Document resource parsing with examples #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 19, 2023
Merged

docs: Document resource parsing with examples #297

merged 11 commits into from
Oct 19, 2023

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Oct 17, 2023

Description

Document the mapping of CRD resource definitions onto spark conf settings.
Fixes #294

Also removed spark.kubernetes.{executor|driver}.{request|limit}.memory as it does not appear in the spark code/branch-3.4.

CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/106/
CI: 🟢 https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/108/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@adwk67 adwk67 marked this pull request as ready for review October 17, 2023 14:44
@adwk67 adwk67 requested a review from a team October 17, 2023 14:50
@adwk67 adwk67 requested a review from sbernauer October 18, 2023 13:18
@adwk67
Copy link
Member Author

adwk67 commented Oct 18, 2023

Jenkins: 🟢 ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/108

@adwk67 adwk67 requested a review from a team October 18, 2023 16:01
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adwk67 adwk67 requested a review from sbernauer October 19, 2023 09:33
@adwk67 adwk67 added this pull request to the merge queue Oct 19, 2023
Merged via the queue into main with commit 4813cfa Oct 19, 2023
@bors bors bot deleted the docs/resources branch October 19, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: improve resource usage documentation
3 participants