-
-
Notifications
You must be signed in to change notification settings - Fork 3
JVM config overrides #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JVM config overrides #272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unrelated, but could you please also remove -Djavax.net.debug=ssl
from rust/operator-binary/src/history_controller.rs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Context: The CRD will be switched to using CommonConfiguration from operator-rs for stuff like config, configOverrides or podOverrides.
I would prefer to first do the switch and afterwards add the configOverrides for security.properties, so that we avoid having two breaking changes directly after each other. But this is no strong feeling, as I don't expect users to configure this in the next weeks.
So I would leave the decision about the order up to you, as long as we have the switch in 23.11
This reverts commit e8d79f3.
Can we please remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Context: The CRD will be switched to using CommonConfiguration from operator-rs for stuff like config, configOverrides or podOverrides.
I would prefer to first do the switch and afterwards add the configOverrides for security.properties, so that we avoid having two breaking changes directly after each other. But this is no strong feeling, as I don't expect users to configure this in the next weeks.
So I would leave the decision about the order up to you, as long as we have the switch in 23.11
Created follow up issue: #273 |
Description
CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/100/
Definition of Done Checklist