Skip to content

JVM config overrides #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 18, 2023
Merged

JVM config overrides #272

merged 13 commits into from
Aug 18, 2023

Conversation

razvan
Copy link
Member

@razvan razvan commented Aug 15, 2023

Description

CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/100/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [x] Proper release label has been added

@razvan razvan marked this pull request as ready for review August 16, 2023 13:47
@razvan razvan requested a review from a team August 16, 2023 13:47
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unrelated, but could you please also remove -Djavax.net.debug=ssl from rust/operator-binary/src/history_controller.rs ?

@razvan razvan requested a review from sbernauer August 17, 2023 14:42
sbernauer
sbernauer previously approved these changes Aug 18, 2023
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context: The CRD will be switched to using CommonConfiguration from operator-rs for stuff like config, configOverrides or podOverrides.
I would prefer to first do the switch and afterwards add the configOverrides for security.properties, so that we avoid having two breaking changes directly after each other. But this is no strong feeling, as I don't expect users to configure this in the next weeks.

So I would leave the decision about the order up to you, as long as we have the switch in 23.11

@sbernauer
Copy link
Member

Can we please remove -Djavax.net.debug settings from all files? :)

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context: The CRD will be switched to using CommonConfiguration from operator-rs for stuff like config, configOverrides or podOverrides.
I would prefer to first do the switch and afterwards add the configOverrides for security.properties, so that we avoid having two breaking changes directly after each other. But this is no strong feeling, as I don't expect users to configure this in the next weeks.

So I would leave the decision about the order up to you, as long as we have the switch in 23.11

@razvan
Copy link
Member Author

razvan commented Aug 18, 2023

Created follow up issue: #273

@razvan razvan added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit 2c807ca Aug 18, 2023
@bors bors bot deleted the feat/jvm-sec-overrides branch August 18, 2023 10:04
@lfrancke lfrancke added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/23.11.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants