Skip to content

[Merged by Bors] - Support specifying Service type #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sbernauer
Copy link
Member

Description

For stackabletech/issues#360

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer force-pushed the feat/service-type branch from ef54129 to 2f2c26d Compare April 6, 2023 11:22
@sbernauer sbernauer self-assigned this Apr 6, 2023
@sbernauer sbernauer requested review from razvan and maltesander April 6, 2023 11:23
@sbernauer
Copy link
Member Author

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Lets wait for @razvan review before merging.

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The history test fails on OpenShift.

@sbernauer
Copy link
Member Author

I would have though that this PR does not cause this failure, but who knows? ;)
Do you have any error message or a cluster I can connect to to debug the problem?

@razvan
Copy link
Member

razvan commented Apr 13, 2023

Works now. The problem seems to have been a "broken" installation of the secret-operator. After reinstalling it, it worked.

@sbernauer
Copy link
Member Author

Alright thx! kuttl tests on jenkins passed as well

@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 13, 2023
@bors
Copy link

bors bot commented Apr 13, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Support specifying Service type [Merged by Bors] - Support specifying Service type Apr 13, 2023
@bors bors bot closed this Apr 13, 2023
@bors bors bot deleted the feat/service-type branch April 13, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants