-
-
Notifications
You must be signed in to change notification settings - Fork 3
[Merged by Bors] - Support specifying Service type #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ef54129
to
2f2c26d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Lets wait for @razvan review before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The history test fails on OpenShift.
I would have though that this PR does not cause this failure, but who knows? ;) |
Works now. The problem seems to have been a "broken" installation of the secret-operator. After reinstalling it, it worked. |
Alright thx! kuttl tests on jenkins passed as well |
bors r+ |
# Description For stackabletech/issues#360
Pull request successfully merged into main. Build succeeded: |
Description
For stackabletech/issues#360
Definition of Done Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information