-
-
Notifications
You must be signed in to change notification settings - Fork 3
[Merged by Bors] - fix resource limit usage #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM overall
I'm going to give it a try by using it within the warehouse demo
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
Tests it out and seemed to work fine 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % remaining two comments. worked fine 👍
Co-authored-by: Sebastian Bernauer <[email protected]>
bors merge |
# Description - Restores setting # of executor instances - Define spark conf settings as well as defining the pod template - set kuberenetes.driver/executor.* from CRD directly - use cpu limit to set driver/executor.cores - Integration test to test/illustrate - just resource limits - just spark.conf settings - just defaults Fixes #161. Jenkins: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/41/
Pull request successfully merged into main. Build succeeded: |
Description
Fixes #161.
Jenkins: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/41/
Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information