Properly handle compute resources and number of executors #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
commented
Oct 12, 2022
Comment on lines
+949
to
+950
| // TODO Switch to assert!(command.contains(&"--conf spark.driver.cores=2".to_string())); | ||
| assert!(command.contains(&"--conf spark.driver.cores=150m".to_string())); |
There was a problem hiding this comment.
Letting the test pass so that i get a pr-version
Suggested change
| // TODO Switch to assert!(command.contains(&"--conf spark.driver.cores=2".to_string())); | |
| assert!(command.contains(&"--conf spark.driver.cores=150m".to_string())); | |
| assert!(command.contains(&"--conf spark.driver.cores=2".to_string())); |
sbernauer
changed the title
|
Closing this as it's more complicated. We have #161 to track the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up of #147
Fixes the bug that passing the number of executors was accidentally removed.
It also fixes the unneeded pvc storage request.
It also adds the correct
spark.driver.coresandspark.executor.coresso that the Pods use the available resources.Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information