Skip to content

[Merged by Bors] - Added owner-ref to pod templates #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Added owner-ref to pod templates #104

wants to merge 3 commits into from

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Jul 20, 2022 •
edited
Loading

Description

  • added an owner-reference to the pod templates for driver and executor(s) so that their pods are cleaned up along with the SparkApplication
  • also fixed broken file name in one of the examples

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@adwk67 adwk67 marked this pull request as ready for review July 20, 2022 15:22
@adwk67 adwk67 requested a review from a team July 20, 2022 15:22
sbernauer
sbernauer reviewed Jul 21, 2022
View reviewed changes
sbernauer
sbernauer approved these changes Jul 21, 2022
View reviewed changes
@adwk67
Copy link
Member Author

adwk67 commented Jul 21, 2022

bors merge

bors bot pushed a commit that referenced this pull request Jul 21, 2022
@adwk67
Added owner-ref to pod templates (#104)
31f099a 
# Description

- added an owner-reference to the pod templates for driver and executor(s) so that their pods are cleaned up along with the SparkApplication
- also fixed broken file name in one of the examples
@bors
Copy link

bors bot commented Jul 21, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Added owner-ref to pod templates [Merged by Bors] - Added owner-ref to pod templates Jul 21, 2022
@bors bors bot closed this Jul 21, 2022
@bors bors bot deleted the owner-ref-bugfix branch July 21, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adwk67 @sbernauer