Skip to content

Commit a76d5e1

Browse files
committed
fix(tests): update Python script for logging tests
1 parent a93de66 commit a76d5e1

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

rust/crd/src/lib.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -484,11 +484,8 @@ impl SparkApplication {
484484
format!("--conf spark.kubernetes.authenticate.driver.serviceAccountName={}", serviceaccount_name),
485485
format!("--conf spark.driver.defaultJavaOptions=-Dlog4j.configurationFile={VOLUME_MOUNT_PATH_LOG_CONFIG}/{LOG4J2_CONFIG_FILE}"),
486486
format!("--conf spark.driver.extraClassPath=/stackable/spark/extra-jars/*"),
487-
//"--conf spark.driver.userClassPathFirst=true".to_string(),
488-
"--conf spark.driver.userClassPathFirst=true".to_string(),
489487
format!("--conf spark.executor.defaultJavaOptions=-Dlog4j.configurationFile={VOLUME_MOUNT_PATH_LOG_CONFIG}/{LOG4J2_CONFIG_FILE}"),
490488
format!("--conf spark.executor.extraClassPath=/stackable/spark/extra-jars/*"),
491-
//"--conf spark.executor.userClassPathFirst=true".to_string(),
492489
]);
493490

494491
// See https://spark.apache.org/docs/latest/running-on-kubernetes.html#dependency-management

tests/templates/kuttl/logging/test_log_aggregation.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,12 @@ def check_sent_events():
3737
assert sentEvents is None or \
3838
sentEvents['sentEventsTotal'] == 0, \
3939
'Invalid log events were sent.'
40+
elif componentId.find('LogConfigSubmitSpark') > 0:
41+
# [*LogConfigSubmitSpark] components do not log in XML format
42+
# because spark-submit doesn't know about the /stackable/spark/extra-jars folder.
43+
assert sentEvents is None or \
44+
sentEvents['sentEventsTotal'] == 0, \
45+
f'Found events for {componentId} but did not expect any.'
4046
else:
4147
assert sentEvents is not None and \
4248
sentEvents['sentEventsTotal'] > 0, \

tests/test-definition.yaml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,15 @@ dimensions:
55
- "false"
66
- name: spark
77
values:
8-
# - 3.4.1
8+
- 3.4.1
99
- 3.5.0
1010
# Alternatively, if you want to use a custom image, append a comma and the full image name to the product version
1111
# as in the example below.
12-
#- 3.4.1,docker.stackable.tech/sandbox/spark-k8s:3.4.1-stackable0.0.0-dev
13-
#- 3.5.0,docker.stackable.tech/sandbox/spark-k8s:3.5.0-stackable0.0.0-dev
12+
# - 3.5.0,docker.stackable.tech/sandbox/spark-k8s:3.5.0-stackable0.0.0-dev
1413
- name: spark-delta
1514
values:
16-
# - 3.5.0
17-
- 3.5.0,docker.stackable.tech/sandbox/spark-k8s:3.5.0-stackable0.0.0-dev
18-
15+
- 3.5.0
16+
# - 3.5.0,docker.stackable.tech/sandbox/spark-k8s:3.5.0-stackable0.0.0-dev
1917
- name: ny-tlc-report
2018
values:
2119
- 0.1.0

0 commit comments

Comments
 (0)