Skip to content

Commit a93de66

Browse files
committed
Revert extra-jars removal but don't set the userClassPathFirst properties.
1 parent fa0f40f commit a93de66

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

rust/crd/src/lib.rs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,12 @@ impl SparkApplication {
483483
format!("--conf spark.kubernetes.executor.container.image={}", spark_image.to_string()),
484484
format!("--conf spark.kubernetes.authenticate.driver.serviceAccountName={}", serviceaccount_name),
485485
format!("--conf spark.driver.defaultJavaOptions=-Dlog4j.configurationFile={VOLUME_MOUNT_PATH_LOG_CONFIG}/{LOG4J2_CONFIG_FILE}"),
486-
format!("--conf spark.executor.defaultJavaOptions=-Dlog4j.configurationFile={VOLUME_MOUNT_PATH_LOG_CONFIG}/{LOG4J2_CONFIG_FILE}")
486+
format!("--conf spark.driver.extraClassPath=/stackable/spark/extra-jars/*"),
487+
//"--conf spark.driver.userClassPathFirst=true".to_string(),
488+
"--conf spark.driver.userClassPathFirst=true".to_string(),
489+
format!("--conf spark.executor.defaultJavaOptions=-Dlog4j.configurationFile={VOLUME_MOUNT_PATH_LOG_CONFIG}/{LOG4J2_CONFIG_FILE}"),
490+
format!("--conf spark.executor.extraClassPath=/stackable/spark/extra-jars/*"),
491+
//"--conf spark.executor.userClassPathFirst=true".to_string(),
487492
]);
488493

489494
// See https://spark.apache.org/docs/latest/running-on-kubernetes.html#dependency-management

rust/operator-binary/src/history/history_controller.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -671,6 +671,11 @@ fn env_vars(s3logdir: &S3LogDir) -> Vec<EnvVar> {
671671
value: Some("true".into()),
672672
value_from: None,
673673
});
674+
vars.push(EnvVar {
675+
name: "SPARK_DAEMON_CLASSPATH".to_string(),
676+
value: Some("/stackable/spark/extra-jars/*".into()),
677+
value_from: None,
678+
});
674679

675680
let mut history_opts = vec![
676681
format!("-Dlog4j.configurationFile={VOLUME_MOUNT_PATH_LOG_CONFIG}/{LOG4J2_CONFIG_FILE}"),

tests/test-definition.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ dimensions:
66
- name: spark
77
values:
88
# - 3.4.1
9-
# - 3.5.0
9+
- 3.5.0
1010
# Alternatively, if you want to use a custom image, append a comma and the full image name to the product version
1111
# as in the example below.
12-
- 3.4.1,docker.stackable.tech/sandbox/spark-k8s:3.4.1-stackable0.0.0-dev
13-
- 3.5.0,docker.stackable.tech/sandbox/spark-k8s:3.5.0-stackable0.0.0-dev
12+
#- 3.4.1,docker.stackable.tech/sandbox/spark-k8s:3.4.1-stackable0.0.0-dev
13+
#- 3.5.0,docker.stackable.tech/sandbox/spark-k8s:3.5.0-stackable0.0.0-dev
1414
- name: spark-delta
1515
values:
1616
# - 3.5.0

0 commit comments

Comments
 (0)