Skip to content

Add documentation templating #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Add documentation templating #160

wants to merge 4 commits into from

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Jul 25, 2022

maltesander
maltesander reviewed Jul 25, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing

maltesander
maltesander approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We discussed and merge as is. This requires all tools affected by templating to have the installation.adoc manually removed as well as the the nav.adoc updated (in the resulting templating PRs).

@fhennig fhennig closed this Jul 27, 2022
@fhennig
Copy link
Contributor Author

fhennig commented Jul 27, 2022

We're not doing it, there's too much different stuff in there it can't be templated

@lfrancke lfrancke deleted the docs-templating branch April 27, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhennig @maltesander