Skip to content

feat: add DeploymentConditionBuilder #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 1, 2025
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/stackable-operator/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ All notable changes to this project will be documented in this file.
### Added

- Add Deployments to `ClusterResource`s ([#992]).
- Add `DeploymentConditionBuilder` ([#993]).

### Changed

Expand All @@ -15,6 +16,7 @@ All notable changes to this project will be documented in this file.
[#950]: https://github.com/stackabletech/operator-rs/pull/950
[#989]: https://github.com/stackabletech/operator-rs/pull/989
[#992]: https://github.com/stackabletech/operator-rs/pull/992
[#993]: https://github.com/stackabletech/operator-rs/pull/993

## [0.87.5] - 2025-03-19

Expand Down
191 changes: 191 additions & 0 deletions crates/stackable-operator/src/status/condition/deployment.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,191 @@
use std::cmp;

use k8s_openapi::api::apps::v1::Deployment;
use kube::ResourceExt;

use crate::status::condition::{
ClusterCondition, ClusterConditionSet, ClusterConditionStatus, ClusterConditionType,
ConditionBuilder,
};

/// Default implementation to build [`ClusterCondition`]s for
/// `Deployment` resources.
///
/// Currently only the `ClusterConditionType::Available` is implemented. This will be extended
/// to support all `ClusterConditionType`s in the future.
#[derive(Default)]
pub struct DeploymentConditionBuilder {
deployments: Vec<Deployment>,
}

impl ConditionBuilder for DeploymentConditionBuilder {
fn build_conditions(&self) -> ClusterConditionSet {
vec![self.available()].into()
}
}

impl DeploymentConditionBuilder {
pub fn add(&mut self, dplmt: Deployment) {
self.deployments.push(dplmt);
}

fn available(&self) -> ClusterCondition {
let mut available = ClusterConditionStatus::True;
let mut unavailable_resources = vec![];
for deployment in &self.deployments {
let current_status = Self::deployment_available(deployment);

if current_status != ClusterConditionStatus::True {
unavailable_resources.push(deployment.name_any())
}

available = cmp::max(available, current_status);
}

// We need to sort here to make sure roles and role groups are not changing position
// due to the HashMap (random order) logic.
unavailable_resources.sort();

let message = match available {
ClusterConditionStatus::True => {
"All Deployments have the requested amount of ready replicas.".to_string()
}
ClusterConditionStatus::False => {
format!("Deployment {unavailable_resources:?} missing ready replicas.")
}
ClusterConditionStatus::Unknown => {
"Deployment status cannot be determined.".to_string()
}
};

ClusterCondition {
reason: None,
message: Some(message),
status: available,
type_: ClusterConditionType::Available,
last_transition_time: None,
last_update_time: None,
}
}

/// Returns a condition "Available: True" if the number of requested replicas matches
/// the number of available replicas. In addition, there needs to be at least one replica
/// available.
fn deployment_available(dplmt: &Deployment) -> ClusterConditionStatus {
let requested_replicas = dplmt
.spec
.as_ref()
.and_then(|spec| spec.replicas)
.unwrap_or_default();
let available_replicas = dplmt
.status
.as_ref()
.and_then(|status| status.available_replicas)
.unwrap_or_default();

if requested_replicas == available_replicas && requested_replicas != 0 {
ClusterConditionStatus::True
} else {
ClusterConditionStatus::False
}
}
}

#[cfg(test)]
mod tests {
use k8s_openapi::api::apps::v1::{Deployment, DeploymentSpec, DeploymentStatus};

use crate::status::condition::{
deployment::DeploymentConditionBuilder, ClusterCondition, ClusterConditionStatus,
ClusterConditionType, ConditionBuilder,
};

fn build_deployment(spec_replicas: i32, available_replicas: i32) -> Deployment {
Deployment {
spec: Some(DeploymentSpec {
replicas: Some(spec_replicas),
..DeploymentSpec::default()
}),
status: Some(DeploymentStatus {
available_replicas: Some(available_replicas),
..DeploymentStatus::default()
}),
..Deployment::default()
}
}

#[test]
fn available() {
let deployment = build_deployment(3, 3);

assert_eq!(
DeploymentConditionBuilder::deployment_available(&deployment),
ClusterConditionStatus::True
);
}

#[test]
fn unavailable() {
let deployment = build_deployment(3, 2);

assert_eq!(
DeploymentConditionBuilder::deployment_available(&deployment),
ClusterConditionStatus::False
);

let deployment = build_deployment(3, 4);

assert_eq!(
DeploymentConditionBuilder::deployment_available(&deployment),
ClusterConditionStatus::False
);
}

#[test]
fn condition_available() {
let mut deployment_condition_builder = DeploymentConditionBuilder::default();
deployment_condition_builder.add(build_deployment(3, 3));

let conditions = deployment_condition_builder.build_conditions();

let got = conditions
.conditions
.get::<usize>(ClusterConditionType::Available.into())
.cloned()
.unwrap()
.unwrap();

let expected = ClusterCondition {
type_: ClusterConditionType::Available,
status: ClusterConditionStatus::True,
..ClusterCondition::default()
};

assert_eq!(got.type_, expected.type_);
assert_eq!(got.status, expected.status);
}

#[test]
fn condition_unavailable() {
let mut deployment_condition_builder = DeploymentConditionBuilder::default();
deployment_condition_builder.add(build_deployment(3, 2));

let conditions = deployment_condition_builder.build_conditions();

let got = conditions
.conditions
.get::<usize>(ClusterConditionType::Available.into())
.cloned()
.unwrap()
.unwrap();

let expected = ClusterCondition {
type_: ClusterConditionType::Available,
status: ClusterConditionStatus::False,
..ClusterCondition::default()
};

assert_eq!(got.type_, expected.type_);
assert_eq!(got.status, expected.status);
}
}
1 change: 1 addition & 0 deletions crates/stackable-operator/src/status/condition/mod.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
pub mod daemonset;
pub mod deployment;
pub mod operations;
pub mod statefulset;

Expand Down