chore: Lower requested resources in the logging test #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logging test creates the following pods:
They request a lot of CPU resources, especially because a Vector container is started for every HDFS pod.
The logging test usually passes if the other test which is running in parallel, does not request too much CPU. But if two logging tests for different Hadoop versions are running in parallel then not all pods can be scheduled (on our AKS cluster) due to insufficient CPU resources. If pods from both tests cannot be scheduled then the tests are deadlocked and will fail both.
Failed test due to deadlock: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/119/
The solution is to lower the requested resources.
This pull request lowers only the CPU requests for the HDFS containers because this can be easily done in the configuration. Lowering the requests for the Vector containers would require pod overrides (https://github.com/stackabletech/hdfs-operator/blob/23.11.0/rust/operator-binary/src/container.rs#L181-L187). However, this seems to be sufficient.
Successful test with lowered resources: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/121/