Skip to content

chore: Add an integration test for profiling #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 8, 2024
Merged

chore: Add an integration test for profiling #465

merged 14 commits into from
Feb 8, 2024
+319 −0

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Feb 2, 2024 •
edited
Loading

Description

Add an integration test for profiling

Tests stackabletech/docker-images#540

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@siegfriedweber siegfriedweber self-assigned this Feb 2, 2024
@siegfriedweber siegfriedweber mentioned this pull request Feb 5, 2024
Closed
4 tasks
@siegfriedweber
Copy link
Member Author

Tests have succeeded:

https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/117/

@siegfriedweber siegfriedweber mentioned this pull request Feb 5, 2024
Merged
@siegfriedweber siegfriedweber marked this pull request as ready for review February 6, 2024 07:52
@siegfriedweber siegfriedweber requested a review from a team February 6, 2024 07:53
@siegfriedweber siegfriedweber linked an issue Feb 6, 2024 that may be closed by this pull request
Include async-profiler v2 into the HDFS & HBase images stackabletech/docker-images#532
Closed
4 tasks
@siegfriedweber
Copy link
Member Author

https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hdfs-operator-it-custom/122/

razvan
razvan previously approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@siegfriedweber siegfriedweber requested a review from razvan February 8, 2024 15:59
razvan
razvan approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@siegfriedweber siegfriedweber added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit ded0d65 Feb 8, 2024
@siegfriedweber siegfriedweber deleted the chore/profiling-test branch February 8, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include async-profiler v2 into the HDFS & HBase images
2 participants
@siegfriedweber @razvan