Skip to content

Add a section on Export Controls #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 14, 2024
Merged

Add a section on Export Controls #545

merged 10 commits into from
Feb 14, 2024

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Feb 8, 2024 •
edited
Loading

The rendered page can be found here: https://deploy-preview-545--stackable-docs.netlify.app/home/nightly/export

@fhennig The link in the navbar is now dead for 23.11 and previous releases, do we need to back port it somehow or what would you suggest?

@netlify Netlify
Copy link

netlify bot commented Feb 8, 2024 •
edited
Loading

✅ Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit cbc6c4c
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/65ccd7ff41862300087bdeb0
😎 Deploy Preview https://deploy-preview-545--stackable-docs.netlify.app/home/nightly/export
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lfrancke
Copy link
Member Author

lfrancke commented Feb 8, 2024 •
edited
Loading

Requested review by lawyer today.

@fhennig
Copy link
Contributor

fhennig commented Feb 12, 2024 •
edited
Loading

The link in the navbar is now dead for 23.11 and previous releases, do we need to back port it somehow or what would you suggest?

Oh, good point, this is actually also the case for the other pages in that menu. Yes I believe backporting them would be the easiest in this case. It also makes sense since the information applies to all releases.

I made a bug issue for this: #547 - I can take care of it if you want to. You can put it on the board and assign me if you want to.

We can also consider to not version these pages together with the platform, but pulling them out now is a bit of work (just wanted to mention the option)

@lfrancke
Copy link
Member Author

Thank you for the offer.

Yes, please do put it on the board and work on it at when you have the time.

@fhennig
Copy link
Contributor

fhennig commented Feb 13, 2024

#547 done

@lfrancke lfrancke marked this pull request as ready for review February 13, 2024 20:00
@adwk67 adwk67 self-requested a review February 14, 2024 14:01
adwk67
adwk67 requested changes Feb 14, 2024
View reviewed changes
@lfrancke
Copy link
Member Author

Thanks for the review and the suggestions

@lfrancke lfrancke requested a review from adwk67 February 14, 2024 15:11
adwk67
adwk67 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lfrancke lfrancke added this pull request to the merge queue Feb 14, 2024
Merged via the queue into main with commit 00c1c56 Feb 14, 2024
@lfrancke lfrancke deleted the export branch February 14, 2024 15:15
@lfrancke lfrancke added release-note Denotes a PR that will be considered when it comes time to generate release notes. release/24.3.0 labels Feb 15, 2024
lfrancke added a commit that referenced this pull request Feb 19, 2024
@lfrancke @adwk67
Add a section on Export Controls (#545)
e1c9e5e 
* Add a section on Export Controls

* Add link to EAR

* Update navbar

* Fix label

* Minor clarifications

* Update modules/ROOT/pages/export.adoc

Co-authored-by: Andrew Kenworthy <[email protected]>

* Update modules/ROOT/pages/export.adoc

Co-authored-by: Andrew Kenworthy <[email protected]>

* Update modules/ROOT/pages/export.adoc

Co-authored-by: Andrew Kenworthy <[email protected]>

* Update modules/ROOT/pages/export.adoc

Co-authored-by: Andrew Kenworthy <[email protected]>

---------

Co-authored-by: Andrew Kenworthy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees
No one assigned
Labels
release/24.3.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfrancke @fhennig @adwk67