Skip to content

Feat: new release scripts, component attribute for CRD docs links #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2023
Merged

Feat: new release scripts, component attribute for CRD docs links #511

merged 2 commits into from
Dec 19, 2023

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 18, 2023 •
edited
Loading

  • I've added 3 new variables in the antora.yml, which is component and version specific. The variables are for making versioned links to the CRD docs.
  • To make releases easier, I've added two scripts to first make a release branch and then also publish new release docs. Otherwise another manual step would be necessary for changing the CRD docs version as well. fixes Release branch script #510
  • I have removed the obsolete gitpod playbook.
  • I have removed the old version_bump.sh script which was used before we started using release branches.

@netlify Netlify
Copy link

netlify bot commented Dec 18, 2023 •
edited
Loading

✅ Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit 3ba68e0
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/65808384a7dd4600084d4883
😎 Deploy Preview https://deploy-preview-511--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fhennig fhennig marked this pull request as ready for review December 18, 2023 17:38
@fhennig fhennig mentioned this pull request Dec 19, 2023
Merged
@fhennig fhennig requested a review from a team December 19, 2023 09:33
@fhennig fhennig self-assigned this Dec 19, 2023
sbernauer
sbernauer approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have not review the two new scripts, as I assume they are copied from somewhere else

@fhennig fhennig added this pull request to the merge queue Dec 19, 2023
Merged via the queue into main with commit dcaa3f8 Dec 19, 2023
@fhennig fhennig deleted the feat/new-release-scripts-cleanup branch December 19, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@fhennig fhennig

Labels
status/blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release branch script
2 participants
@fhennig @sbernauer