Skip to content

faster run_sql with shared database connection #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

lovasoa
Copy link
Collaborator

@lovasoa lovasoa commented May 30, 2024

see #338

…n `sqlpage.run_sql` instead of opening a new one

fixes #338
@lovasoa lovasoa force-pushed the better_run_sql_management branch from c8e032e to 8b700be Compare June 1, 2024 15:14
@lovasoa
Copy link
Collaborator Author

lovasoa commented Jun 1, 2024

@vlasky @guspower : this ended up being a larger change than expected... Would any of you be available to test this on your applications before I release the change for everyone ? I would like to make sure the change does not have any unexpected consequences.

@lovasoa lovasoa marked this pull request as ready for review June 1, 2024 15:59
@guspower
Copy link
Contributor

guspower commented Jun 1, 2024

@lovasoa yes I can take it for a spin tomorrow and let you know.

@lovasoa lovasoa changed the title [WIP] faster run_sql with shared database connection faster run_sql with shared database connection Jun 1, 2024
@lovasoa lovasoa merged commit 8add49d into main Jun 2, 2024
9 checks passed
@lovasoa lovasoa deleted the better_run_sql_management branch June 2, 2024 17:00
@guspower
Copy link
Contributor

guspower commented Jun 3, 2024

FYI I cloned better_run_sql_management yesterday and ran the release build against a reasonable size app - no issues functionally. I was going to cook up a performance test to compare against the previous release but I see you've merged in so I'll hold off for now.

@lovasoa
Copy link
Collaborator Author

lovasoa commented Jun 3, 2024

Great to hear it works. And I actually would be very interested in the numbers you get on your application in a performance test.

@guspower
Copy link
Contributor

guspower commented Jun 3, 2024

Me too! First I am going to set up a functional check using spider and then figure out how to run a perf test (which is always a pain :) ) I doubt I'll get one running this week due to workload, but when I do I will share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants