New RSS component #252
Merged
New RSS component #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovasoa
requested changes
Mar 4, 2024
There was a problem hiding this comment.
Isn't it cumbersome to require an RFC-822 date ?
I think people should be able to use native date objects from their database (which are interpreted as ISO 8601 by sqlpage).
Also, we should probably add support for podcast-specific attributes, which shouldn't require a lot of changes and would be useful.
I'm making a few changes directly in the pr.
|
I made a few changes, let me know what you think. We still need to provide a RFC-822 date formater to the templates to make this work. |
|
Yes, perfect. It's ok for me |
lovasoa
added a commit
that referenced
this pull request
Mar 5, 2024
* Produces a data flow in the RSS format * add documentation and rss reference * more complete rss component, with support for podcasts * podcast changes * documentation * format dates as rfc2822 * extract template helpers * extract more helpers * remove unnecassary error handling * fmt * two-param helpers * rfc2822_date_helper * test rfc date formatter * accept dates with or without time * remove unneeded line breaks --------- Co-authored-by: Olivier Auverlot <[email protected]> Co-authored-by: lovasoa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Produces a data flow in the RSS format. To use this component, you must first returning an HTTP header with the "application/rss+xml" content type (see http_header component). Next, you must use the shell-empty component to avoid that SQLPage generates HTML code. TIPS: If you don''t want change the page shell, you can also use the _sqlpage_embed URL parameter.