Skip to content

CommandExceptionResolver beans should have order #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvalkeal opened this issue Jan 25, 2023 · 0 comments
Closed

CommandExceptionResolver beans should have order #634

jvalkeal opened this issue Jan 25, 2023 · 0 comments
Labels
branch/3.0.x Issue for a branch for/backport For backporting type/enhancement Is an enhancement request
Milestone
3.1.0-M1

Comments

@jvalkeal
Copy link
Contributor

Currently we have only one added as bean that being CommandParserExceptionResolver. It was always meant that this would pick CommandParserExceptionsException and then user could create their own resolvers. Issue is that if user creates resolver which handles everything it's not possible make sure if that is used before/after default ones from spring-shell itself.

That's why CommandParserExceptionResolver needs an order as it defaults to lowest precedence.
@jvalkeal jvalkeal added type/enhancement Is an enhancement request for/backport For backporting branch/3.0.x Issue for a branch labels Jan 25, 2023
@jvalkeal jvalkeal added this to the 3.1.0-M1 milestone Jan 25, 2023
@github-actions github-actions bot mentioned this issue Jan 25, 2023
Closed
jvalkeal added a commit that referenced this issue Jan 25, 2023
@jvalkeal
Define CommandExceptionResolver bean order
32fc723 
- CommandParserExceptionResolver uses default bean
  order -100.
- Backport #634
- Fixes #635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch/3.0.x Issue for a branch for/backport For backporting type/enhancement Is an enhancement request
Projects
None yet
Milestone
3.1.0-M1
Development

No branches or pull requests
1 participant
@jvalkeal