Skip to content

backport(495) Incorrect completion for options #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvalkeal opened this issue Aug 4, 2022 · 0 comments
Closed

backport(495) Incorrect completion for options #498

jvalkeal opened this issue Aug 4, 2022 · 0 comments
Labels
type/backport Is a issue to track backport, use with branch/xxx
Milestone
2.1.1

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Aug 4, 2022

No description provided.

@jvalkeal jvalkeal added the type/backport Is a issue to track backport, use with branch/xxx label Aug 4, 2022
@jvalkeal jvalkeal added this to the 2.1.1 milestone Aug 4, 2022
jvalkeal added a commit that referenced this issue Aug 4, 2022
@jvalkeal
Apply correct completion
d6ab2e5 
- This commit fixes two issues.
- Firstly complete with correct option as existing bug was
  to wrongly always complete with first option which used
  wrong provider.
- Secondly filter out duplicate option proposals giving better
  result when options is already in place.
- Backport #495
- Fixes #498

(cherry picked from commit a143d25)
@jvalkeal jvalkeal closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/backport Is a issue to track backport, use with branch/xxx
Projects
None yet
Milestone
2.1.1
Development

No branches or pull requests
1 participant
@jvalkeal