Skip to content

Spring shell is defaulting to the base Jakarta validator #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
terminalsin opened this issue Aug 1, 2022 · 0 comments · Fixed by #494
Closed

Spring shell is defaulting to the base Jakarta validator #493

terminalsin opened this issue Aug 1, 2022 · 0 comments · Fixed by #494
Labels
for/backport For backporting
Milestone
3.0.0-M1

Comments

@terminalsin
Copy link
Contributor

In the InvocableShellMethod, the doInvoke method reverts to the base Validator as opposed to the context one. This effectively prevents (Spring Boot from injecting beans into the JSR-303 Bean Validation API)[https://docs.spring.io/spring-framework/docs/3.0.0.RC1/reference/html/ch05s07.html].

After some debugging, it's been retraced to the following:
Image

This is most likely a leftover from debugging and should be omitted to allow for the class Validator to be used.
@terminalsin terminalsin mentioned this issue Aug 1, 2022
Merged
@jvalkeal jvalkeal added this to the 3.0.0-M1 milestone Aug 2, 2022
jvalkeal pushed a commit that referenced this issue Aug 2, 2022
@terminalsin @jvalkeal
Fix ShellMethod not using context validator
703ffc8 
(cherry picked from commit 23194d0)

- Backport #493
- Fixes #496
@jvalkeal jvalkeal added the for/backport For backporting label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for/backport For backporting
Projects
None yet
Milestone
3.0.0-M1
Development

Successfully merging a pull request may close this issue.

Fix ShellMethod not using context validator terminalsin-archive/spring-shell
2 participants
@jvalkeal @terminalsin