-
Notifications
You must be signed in to change notification settings - Fork 395
Support JDK FFM #1131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
type/enhancement
Is an enhancement request
Milestone
Comments
jvalkeal
added a commit
to jvalkeal/spring-shell
that referenced
this issue
Aug 30, 2024
- Starter for jline ffm terminal provider - Build changes for compiling with gradle toolchains defaulting to jdk22 - spring-shell-sample-ffm which compiles with jdk22 - ci workflow setups jdk 17/22 - Relates spring-projects#1131
#1132 changed how javadocs are generated as at some point we also need to handle that via toolchain and it was difficult if aggregated javadocs are in a root project(we can't change main jdk). |
jvalkeal
added a commit
to jvalkeal/spring-shell
that referenced
this issue
Aug 30, 2024
- Change toolchain to get configured immediately instead after project evaluation which somehow caused i.e. vscode not detect correct project jdk in use. - Relates spring-projects#1131
jvalkeal
added a commit
that referenced
this issue
Sep 15, 2024
- To prepare jdk17+ code, don't fail if there's more recent javadoc format. - Relates #1131
jvalkeal
added a commit
that referenced
this issue
Sep 15, 2024
- Prepare build so that we can use JUnit tags and define shellIncludeTags/shellExcludeTags from command line to override settings. - Needed for some of a new planned tests which would not work without full build. - Relates #1131
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With
JDK22
a Foreign Function and Memory API came out from a preview which is supposed to be a replacement forJNI
which we heavily rely viaJLine
as that's only way to have better terminal features. JLine's terminal provider system has a support forFFM
together withJNI/JNA
which are more or less deprecated to get removed at some time in a future.Spring Shell
will always follow JDK baseline(JDK17
) from boot/framework but order to addFFM
support we need to start compiling some new modules withJDK22+
.Up until
JDK25
(next LTS) we need to be a relatively aggressive to use latestJDK
(22,23,24) or at least we could not fall behind whatJLine
uses for itsFFM
parts.This issue tracks work for this particular use case.
The text was updated successfully, but these errors were encountered: