Use the custom ServerRequestCache for Oauth2LoginSpec #7734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanik
added
the
in: oauth2
|
Also, the |
|
Hi @sdoxsee I believe the success handler should be using the same as the others |
|
Thanks @fhanik. I think that's for FormLoginSpec as opposed to OAuth2LoginSpec's configure? |
|
Correct. So yes, it's still an issue in the OAuth2LoginSpec. I'll update the PR to encapsulate both use scenarios. |
jgrandja
requested changes
Dec 13, 2019
config/src/main/java/org/springframework/security/config/web/server/ServerHttpSecurity.java
Outdated
Show resolved
Hide resolved
config/src/main/java/org/springframework/security/config/web/server/ServerHttpSecurity.java
Outdated
Show resolved
Hide resolved
config/src/main/java/org/springframework/security/config/web/server/ServerHttpSecurity.java
Show resolved
Hide resolved
jgrandja
approved these changes
Dec 17, 2019
| @@ -76,9 +76,11 @@ | |||
| import org.springframework.security.oauth2.client.web.server.AuthenticatedPrincipalServerOAuth2AuthorizedClientRepository; | |||
| import org.springframework.security.oauth2.client.web.server.OAuth2AuthorizationCodeGrantWebFilter; | |||
| import org.springframework.security.oauth2.client.web.server.OAuth2AuthorizationRequestRedirectWebFilter; | |||
| import org.springframework.security.oauth2.client.web.server.ServerAuthorizationRequestRepository; | |||
| import org.springframework.security.oauth2.client.web.server.ServerOAuth2AuthorizationCodeAuthenticationTokenConverter; | ||
| import org.springframework.security.oauth2.client.web.server.ServerOAuth2AuthorizationRequestResolver; | ||
| import org.springframework.security.oauth2.client.web.server.ServerOAuth2AuthorizedClientRepository; | ||
| import org.springframework.security.oauth2.client.web.server.WebSessionOAuth2ServerAuthorizationRequestRepository; |
|
@fhanik I noticed you applied the "for: backport-to-5.2.x" to this PR, but it needs to be applied to the associated issue instead. The backport bot does not work on PR's. |
on for the default authentication entry point and authentication success handler Fixes spring-projectsgh-7721 spring-projects#7721 Set RequestCache on the Oauth2LoginSpec default authentication success handler import static ReflectionTestUtils.getField Feedback incorporated per spring-projects#7734 (review)
fhanik
added a commit
to fhanik/spring-security
that referenced
this pull request
Dec 18, 2019
on for the default authentication entry point and authentication success handler Fixes spring-projectsgh-7721 spring-projects#7721 Set RequestCache on the Oauth2LoginSpec default authentication success handler import static ReflectionTestUtils.getField Feedback incorporated per spring-projects#7734 (review)
fhanik
added a commit
that referenced
this pull request
Dec 18, 2019
on for the default authentication entry point and authentication success handler Fixes gh-7721 #7721 Set RequestCache on the Oauth2LoginSpec default authentication success handler import static ReflectionTestUtils.getField Feedback incorporated per #7734 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-7721
Test case provided