Override OncePerRequestFilter#getAlreadyFilteredAttributeName in AuthenticationFilter
#17186
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
jgrandja
added
type: bug
| @@ -222,4 +223,9 @@ private Authentication attemptAuthentication(HttpServletRequest request, HttpSer | |||
| return authenticationResult; | |||
| } | |||
|
|
|||
| @Override | |||
| protected String getAlreadyFilteredAttributeName() { | |||
| return getClass().getName() + ".FILTERED"; | |||
There was a problem hiding this comment.
@therepanic This does not solve the issue as 2 instances of AuthenticationFilter in the chain would return the same value from getAlreadyFilteredAttributeName(), resulting in the 2nd AuthenticationFilter never being called.
Please adjust and add a test that demonstrates the fix.
There was a problem hiding this comment.
I apologize for not accurately solving the problem. We do want each AuthenticationFilter instance to be honored in the chain. What I did I guess won't work if the filters are the same and added to the chain. Then I guess we need to use something like identityHashCode for getAlreadyFilteredAttributeName()? I just want to make sure it's right for us. Thanks.
|
I made the changes you asked for. Including adding a test. Before the changes, this test failing because |
…uthenticationFilter` (spring-projects#17173) Signed-off-by: Andrey Litvitski <[email protected]>
This change will enable us to use multiple
AuthenticationFilter.Fix: #17173