Add option to disable anonymous authentication in RSocketSecurity
#17159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therepanic
changed the title
RSocketSecurityRSocketSecurity
spring-projects-issues
added
the
status: waiting-for-triage
|
Hmmm, is the build going down by my mistake or is it not about me? |
…pring-projects#17132) Signed-off-by: Andrey Litvitski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding anonymous interceptor hardcoded to
RSocketSecurity#payloadInterceptorsand is added anyway. I think you should add an option to disable adding anonymous interceptor.I think the most logical way is to add a flag, as in our case I did. I also added a method
disableAnonymouswhich sets the field to true and we no longer add the anonymous interceptor.Fixes: #17132