-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Remove GET request support from Saml2AuthenticationTokenConverter #17099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Closing in favor of #17108 |
jzheaux
pushed a commit
to ngocnhan-tran1996/spring-security
that referenced
this issue
Jun 3, 2025
Closes spring-projectsgh-17099 Signed-off-by: Tran Ngoc Nhan <[email protected]>
jzheaux
added a commit
to ngocnhan-tran1996/spring-security
that referenced
this issue
Jun 3, 2025
jzheaux
pushed a commit
that referenced
this issue
Jun 3, 2025
Closes gh-17099 Signed-off-by: Tran Ngoc Nhan <[email protected]>
jzheaux
added a commit
that referenced
this issue
Jun 3, 2025
jzheaux
added a commit
that referenced
this issue
Jun 3, 2025
jzheaux
added a commit
that referenced
this issue
Jun 3, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Saml2AuthenticationTokenConverter
tests if the HTTP method is GET in order to correctly translateSAMLResponse
parameter.However, neither the SAML spec nor Spring Security support processing the
<saml2:Response>
in a GET request. As such, we should remove this to alleviate confusion.To keep upgrade passive, the first step is to add a property that defaults to
true
:In Spring Security 8, this can be deprecated and switched to
false
, then in Spring Security 9 it can be removed.setShouldInflateResponse
setShouldInflateResponse
The text was updated successfully, but these errors were encountered: