Skip to content

Avoid substring creation when writing a portion of a string to a StringBuilder #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

PENEKhun
Copy link
Contributor

@PENEKhun PENEKhun commented Nov 6, 2023

This PR refactors the 'modify' method by replacing duplicate substring code with a single call to 'append'. This change enhances code readability and maintainability.

Please review and merge this PR. Thank you!

Replace duplicate substring code with a single call to 'append' and Enhance code readability and maintainability
@pivotal-cla
Copy link

@PENEKhun Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@PENEKhun Thank you for signing the Contributor License Agreement!

@wilkinsona wilkinsona added type: task Non user-facing work and removed status: waiting-for-triage Untriaged issue labels Nov 14, 2023
@wilkinsona wilkinsona changed the title Remove duplicate substring code Avoid substring creation when writing a portion of a string to a StringBuilder Nov 14, 2023
@wilkinsona wilkinsona modified the milestones: 3.0.x, 2.0.x Nov 14, 2023
@wilkinsona wilkinsona modified the milestones: 2.0.x, 2.0.8.RELEASE Nov 14, 2023
@wilkinsona
Copy link
Member

Thanks very much, @PENEKhun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task Non user-facing work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants