Skip to content

Dynamic ToC and PDF output #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Buzzardo
Copy link

@Buzzardo Buzzardo commented Mar 9, 2020

I updated the document-production parts of the build files to pick up the dynamic ToC (tocbot) that we use across the portfolio. I also added PDF output (again, in keeping with the rest of the portfolio). In doing so, I updated various versions and other settings.

@wilkinsona
Copy link
Member

Thanks, Jay. I guess this supersedes #577? That has yet to be merged as work on 2.1 still hasn't begun.

@Buzzardo
Copy link
Author

Buzzardo commented Mar 9, 2020

I had forgotten about that one. I figured I had missed spring-restdocs in my modernization push some time back.

Anyway, this one can supercede that one. It doesn't have conflicts, and I'm sure I know more now than I did then.

I'll go close #577

@wilkinsona wilkinsona added this to the 2.1.0.RC1 milestone Mar 9, 2020
@wilkinsona wilkinsona added type: enhancement Enhancement that adds a new feature and removed status: waiting-for-triage Untriaged issue labels Mar 9, 2020
@Buzzardo
Copy link
Author

Is there anything holding up merging this PR or can we go ahead?

@wilkinsona
Copy link
Member

It can't be merged until the 2.0.x branch has been created and master switches to 2.1.

Jay Bryant added 2 commits April 1, 2020 10:51
I updated the document-production parts of the build files to pick up the dynamic ToC (tocbot) that we use across the portfolio. I also added PDF output (again, in keeping with the rest of the portfolio). In doing so, I updated various versions and other settings.
Update to pick up the latest look and feel and better highlighting.
@wilkinsona
Copy link
Member

Superseded by #773.

@wilkinsona wilkinsona closed this Jan 11, 2022
@wilkinsona wilkinsona removed this from the 2.1.0-RC1 milestone Jan 11, 2022
@wilkinsona wilkinsona added the status: superseded Superseded by another issue label Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded Superseded by another issue type: enhancement Enhancement that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants