GH-3114: DeserializationException propagation #3115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: spring-projects#3114 * Since DeserializationExceptionHeader is currently porpagated as a `byte[]`, it encounters some issues when processing the header especially in batch listeners. Fixing this by providing the deserialization header without `byte[]` conversion * Adding test to verify * Refactoring in SerializationTestUtils
artembilan
requested changes
Mar 12, 2024
| @@ -31,6 +31,7 @@ | |||
| import org.apache.kafka.common.header.Headers; | |||
| import org.apache.kafka.common.header.internals.RecordHeader; | |||
|
|
|||
| import org.springframework.kafka.support.serializer.SerializationUtils; | |||
There was a problem hiding this comment.
We need to be sure that there is no package tangle . Usually sub-packages uses their parents.
| @@ -314,6 +316,11 @@ public void toHeaders(Headers source, final Map<String, Object> headers) { | |||
| else if (headerName.equals(KafkaHeaders.LISTENER_INFO) && matchesForInbound(headerName)) { | |||
| headers.put(headerName, new String(header.value(), getCharset())); | |||
| } | |||
| else if ((headerName.equals(SerializationUtils.KEY_DESERIALIZER_EXCEPTION_HEADER) || | |||
| headerName.equals(SerializationUtils.VALUE_DESERIALIZER_EXCEPTION_HEADER)) | |||
| && matchesForInbound(headerName)) { | |||
There was a problem hiding this comment.
I believe this header has to be mapped unconditionally. It is not some what end-user provides.
artembilan
requested changes
Mar 14, 2024
| * | ||
| * @since 2.2 | ||
| * | ||
| */ | ||
| public final class KafkaUtils { | ||
|
|
||
| /** | ||
| * Header name for deserialization exceptions. | ||
| * @since 3.2 |
There was a problem hiding this comment.
According to the GH issue mandate this fix is supposed to be back-ported down to 3.0.x
artembilan
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3114
byte[], it encounters some issues when processing the header especially in batch listeners. Fixing this by providing the deserialization header withoutbyte[]conversion