Skip to content

GH-3057: ReactiveKafkaConsumerTemplate missing receiveBatch method #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

marcusvoltolim
Copy link
Contributor

  • Adding wrapper method receiveBatch in ReactiveKafkaConsumerTemplate.

Closes #3057

…Batch method

* Adding wrapper method `receiveBatch` in ReactiveKafkaConsumerTemplate.

Closes spring-projects#3057
@sobychacko
Copy link
Contributor

@marcusvoltolim Why are you changing the batch semantics in the API? The batchReceives has a return of Flux<Flux<ReceiverRecord<K, V>>> and you are flat mapping it. Why can't we let the user make that decision?

@marcusvoltolim
Copy link
Contributor Author

@marcusvoltolim Why are you changing the batch semantics in the API? The batchReceives has a return of Flux<Flux<ReceiverRecord<K, V>>> and you are flat mapping it. Why can't we let the user make that decision?

I used receiveAutoAck as an example, which does the same thing.

@sobychacko
Copy link
Contributor

Thanks. But, since we are explicitly dealing with a batch API here, producing the output in the raw format might be beneficial without that flatmap operation.

@marcusvoltolim
Copy link
Contributor Author

marcusvoltolim commented Feb 29, 2024

Thanks. But, since we are explicitly dealing with a batch API here, producing the output in the raw format might be beneficial without that flatmap operation.

I agree, and removed the concatMap operation.

@sobychacko
Copy link
Contributor

Any chance you can verify the new API via a unit or integration test?

@marcusvoltolim
Copy link
Contributor Author

marcusvoltolim commented Mar 4, 2024

Any chance you can verify the new API via a unit or integration test?

I will try make this test!

@sobychacko
Copy link
Contributor

@marcusvoltolim Any updates? We have a release next week, and if you want this to be part of that release, then this needs to be addressed sooner so we can progress on the PR.

@sobychacko sobychacko merged commit 179987e into spring-projects:main Mar 18, 2024
@sobychacko
Copy link
Contributor

@marcusvoltolim We merged the PR to include this in the 3.2.0-M2 release. Feel free to work on any testing aspects of this change in a separate PR. Thanks for your PR contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReactiveKafkaConsumerTemplate missing receiveBatch method
2 participants