GH-2481: Global Embedded Broker and JUnit Platform #2482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#2481 The Maven Surefire plugin uses an older version of JUnit platform which is incompatible with the Global embedded broker. Check that the platform version is compatible before attempting to determine if a global embedded broker should be created. Tested with a Spring Boot application.
artembilan
requested changes
Nov 16, 2022
| @@ -84,10 +84,27 @@ public class GlobalEmbeddedKafkaTestExecutionListener implements TestExecutionLi | |||
| public static final String BROKER_PROPERTIES_LOCATION_PROPERTY_NAME = | |||
| "spring.kafka.embedded.broker.properties.location"; | |||
|
|
|||
| private static final boolean JUNIT_PLATFORM_COMPATIBLE; | |||
There was a problem hiding this comment.
Add you name to the @author list, please, 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2481
The Maven Surefire plugin uses an older version of JUnit platform which is incompatible with the Global embedded broker.
Check that the platform version is compatible before attempting to determine if a global embedded broker should be created.
Tested with a Spring Boot application.