GH-2478: Improve RetryTopicComponentFactory Conf
#2480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#2478 Allow users to define a `RetryTopicComponentFactory` bean for use in infrastructure bean definitions. Previously, although `createComponentFactory()` can be overridden, it is called early in the class lifecycle and can't have any dependencies on Spring beans. Now, if the application context contains a unique bean of this type, it is used instead. **Cannot back port due to breaking API changes; work around for 2.9.x is to override one or more of `destinationTopicResolver`, `kafkaConsumerBackoffManager` and/or `retryTopicConfigurer` bean definition methods.**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2478
Allow users to define a
RetryTopicComponentFactorybean for use in infrastructure bean definitions.Previously, although
createComponentFactory()can be overridden, it is called early in the class lifecycle and can't have any dependencies on Spring beans.Now, if the application context contains a unique bean of this type, it is used instead.
Cannot back port due to breaking API changes; work around for 2.9.x is to override one or more of
destinationTopicResolver,kafkaConsumerBackoffManagerand/orretryTopicConfigurerbean definition methods.