[2163] Deprecate ProducerListener in favor of ProducerInterceptor #2225
Conversation
| @@ -35,8 +35,10 @@ | |||
| * @author Artem Bilan | |||
| * | |||
| * @since 2.1.6 | |||
| * | |||
| * @deprecated since 3.0 in favor of {@link org.apache.kafka.clients.producer.ProducerInterceptor} | |||
There was a problem hiding this comment.
Maybe "in favor of CompositeProducerInterceptor" ?
| @@ -32,7 +32,10 @@ | |||
| * | |||
| * @author Marius Bogoevici | |||
| * @author Gary Russell | |||
| * @deprecated since 3.0 in favor of {@link org.apache.kafka.clients.producer.ProducerInterceptor} | |||
There was a problem hiding this comment.
Well, we don't have a LoggingProducerInterceptor to replace with.
I wonder if we need to implement one...
| */ | ||
|
|
||
| @Deprecated(since = "3.0", forRemoval = true) |
There was a problem hiding this comment.
If we deprecate it, we have to replace its usage with the mentioned favor.
Any thoughts what could be done in the that KafkaTemplate for example?
I wonder if you ran your fix locally with the ./gradlew clean check. It must show you that you still use some deprecate API.
Resolves #2255 * Also move test; fix deprecation warnings. **Cherry-pick to 2.9.x**
Resolves #2255 * Also move test; fix deprecation warnings. **Cherry-pick to 2.9.x**
|
Thanks for the contribution; sorry for the delay. After further review, I have decided not to deprecate |
|
Thanks for the update @garyrussell ! |
Resolves #2163
Added Deprecated annotation where ProducerListener was used and suggested using ProducerInterceptor instead
Please let me know if there's anything to be changed.
Thanks