Skip to content

Non-blocking retry using KafkaListener on class level #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Casper-dss opened this issue Feb 1, 2024 · 0 comments · Fixed by #3105
Closed

Non-blocking retry using KafkaListener on class level #3012

Casper-dss opened this issue Feb 1, 2024 · 0 comments · Fixed by #3105
Labels
status: waiting-for-triage type: enhancement
Milestone
3.2.0-M2

Comments

@Casper-dss
Copy link

When using KafkaListener on class level, and configuring non blocking retry with RetryTopicConfiguration, records should go to the retry topic, when failed by exception set as non blocking exceptions.

As stated in the documentation, this functionality is not supported.
"At this time this functionality doesn’t support class level @KafkaListener annotations."

We need this functionality especially when listeners are on class level, with KafkaHandlers handling different payloads. The reason is, if one type of payload fails, we would still be able to process, the other types. Today we can either fail the message completely, or using blocking retry, which will stop processing of all types of payload.

Workaround could be having each payload on separate topics. But this breaks our topic strategy.
Wzy19930507 added a commit to Wzy19930507/spring-kafka that referenced this issue Mar 6, 2024
@Wzy19930507
spring-projectsGH-3012: Non-blocking retries support @KafkaListener o…
18115b4 
…n class level

Fixes: spring-projects#3012

* Non-blocking retries support `@KafkaListener` on class level, include `@RetryableTopic`, `@DltHandler`, `RetryTopicConfiguration`, `RetryTopicConfigurationSupport`.
* Doc and test Non-blocking retries support @KafkaListener on class level.
@Wzy19930507 Wzy19930507 mentioned this issue Mar 6, 2024
Merged
Wzy19930507 added a commit to Wzy19930507/spring-kafka that referenced this issue Mar 13, 2024
@Wzy19930507
spring-projectsGH-3012: Non-blocking retries support @KafkaListener o…
854962a 
…n class level

Fixes: spring-projects#3012

* Non-blocking retries support `@KafkaListener` on class level, include `@RetryableTopic`, `@DltHandler`, `RetryTopicConfiguration`, `RetryTopicConfigurationSupport`.
* Doc and test Non-blocking retries support @KafkaListener on class level.
Wzy19930507 added a commit to Wzy19930507/spring-kafka that referenced this issue Mar 17, 2024
@Wzy19930507
spring-projectsGH-3012: Non-blocking retries support @KafkaListener o…
5986590 
…n class level

Fixes: spring-projects#3012

* Non-blocking retries support `@KafkaListener` on class level, include `@RetryableTopic`, `@DltHandler`, `RetryTopicConfiguration`, `RetryTopicConfigurationSupport`.
* Doc and test Non-blocking retries support @KafkaListener on class level.
@sobychacko sobychacko added this to the 3.2.0-M2 milestone Mar 18, 2024
sobychacko pushed a commit that referenced this issue Mar 18, 2024
@Wzy19930507
GH-3012: Class level KL Non-blocking retry
f28ee55 
Fixes: #3012 

* Non-blocking retries support for `@KafkaListener` on class level, which includes `@RetryableTopic,` `@DltHandler,` `RetryTopicConfiguration,` and `RetryTopicConfigurationSupport.`
* Doc and test for Non-blocking retries support for @KafkaListener on class level.
* Addressing PR review. 

See these earlier related PRs:

#3112
#3107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: waiting-for-triage type: enhancement
Projects
None yet
Milestone
3.2.0-M2
Development

Successfully merging a pull request may close this issue.

GH-3012: Non-blocking retries support @KafkaListener on class level Wzy19930507/spring-kafka
2 participants
@sobychacko @Casper-dss