Skip to content

KafkaAdmin NPE #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Jul 12, 2022 · 0 comments · Fixed by #2346
Closed

KafkaAdmin NPE #2345

garyrussell opened this issue Jul 12, 2022 · 0 comments · Fixed by #2346
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: bug
Milestone
3.0.0-M5

Comments

@garyrussell
Copy link
Contributor

When modifying topic configuration, where that configuration is not currently set on the topic.
@garyrussell garyrussell added this to the 3.0.0-M5 milestone Jul 12, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jul 12, 2022
@garyrussell
spring-projectsGH-2345: Fix Possible NPE in KafkaAdmin
4aaa4e7 
Resolves spring-projects#2345

I haven't been able to reproduce it since, but I saw one occasion where
the existing config property returned null.

Protect against an NPE in that case and add the property to the change
candidates.

Also move the map entry out of the for loop.

**cherry-pick to 2.9.x, 2.8.x**
@garyrussell garyrussell mentioned this issue Jul 12, 2022
Merged
artembilan pushed a commit that referenced this issue Jul 12, 2022
@garyrussell @artembilan
GH-2345: Fix Possible NPE in KafkaAdmin
c978b86 
Resolves #2345

I haven't been able to reproduce it since, but I saw one occasion where
the existing config property returned null.

Protect against an NPE in that case and add the property to the change
candidates.

Also move the map entry out of the for loop.

**cherry-pick to 2.9.x, 2.8.x**
artembilan pushed a commit that referenced this issue Jul 12, 2022
@garyrussell @artembilan
GH-2345: Fix Possible NPE in KafkaAdmin
b1d97b9 
Resolves #2345

I haven't been able to reproduce it since, but I saw one occasion where
the existing config property returned null.

Protect against an NPE in that case and add the property to the change
candidates.

Also move the map entry out of the for loop.

**cherry-pick to 2.9.x, 2.8.x**
artembilan pushed a commit that referenced this issue Jul 12, 2022
@garyrussell @artembilan
GH-2345: Fix Possible NPE in KafkaAdmin
f747329 
Resolves #2345

I haven't been able to reproduce it since, but I saw one occasion where
the existing config property returned null.

Protect against an NPE in that case and add the property to the change
candidates.

Also move the map entry out of the for loop.

**cherry-pick to 2.9.x, 2.8.x**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: bug
Projects
None yet
Milestone
3.0.0-M5
Development

Successfully merging a pull request may close this issue.

GH-2345: Fix Possible NPE in KafkaAdmin garyrussell/spring-kafka
1 participant
@garyrussell