Skip to content

Duplicate headers #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rajh opened this issue Jul 7, 2022 · 1 comment
Closed

Duplicate headers #2335

Rajh opened this issue Jul 7, 2022 · 1 comment

Comments

@Rajh
Copy link

Rajh commented Jul 7, 2022

Hello,

Why KafkaHeaders.EXCEPTION_CAUSE_FQCN is equal to KafkaHeaders.EXCEPTION_FQCN ? Is it a typo ?

public static final String EXCEPTION_CAUSE_FQCN = PREFIX + "exception-fqcn";

public static final String EXCEPTION_FQCN = PREFIX + "exception-fqcn";

And why having 2 sets of headers for DLT (DeadLetterPublishingRecoverer and @RetryableTopic DLT) ?
KafkaHeaders.DLT_EXCEPTION_CAUSE_FQCN KafkaHeaders.EXCEPTION_CAUSE_FQCN

@garyrussell
Copy link
Contributor

Thanks; fixed. The DLT_ headers are for "classic" (blocking) retries with the default DeadLetterPublishingRecoverer.

The ones without the DLT_ are for non-blocking retries; they don't have DLT in the name because the intermediate topics are not dead letter topics, they are delayed retry topics.

There's an argument that says the final publish to the retryable topic DLT should have the DLT prefix but they don't.

Bottom line; use the DLT_ headers when not using retryable topics and the others when you are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants