Skip to content

Add BackOffHandler to FailedRecordTracker #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Marincek opened this issue May 6, 2022 · 1 comment
Closed

Add BackOffHandler to FailedRecordTracker #2262

Marincek opened this issue May 6, 2022 · 1 comment

Comments

@Marincek
Copy link

Marincek commented May 6, 2022

Expected Behavior

BackOffHanlder should encapsulate the handling for the next backoff. FailedRecordTracker will use this interface and call handleNextBackoff in recovered method.

Current Behavior

Currently FailedRecordTracker it is tightly coupled with thread sleep. There is no way to inject another behavior.

Context

The idea is to make FailedRecordTracker able to handle the backoff in different ways. In my case I need to pause the listener on XX minutes.
The other solution for me is to copy several classes just to change one line (FailedRecordTracker,FailedRecordProcessor, DefaultAfterRollbackProcessor)

@Marincek
Copy link
Author

Marincek commented May 6, 2022

PR : #2263

@garyrussell garyrussell added this to the 3.0.0.M5 milestone Jun 27, 2022
garyrussell pushed a commit to garyrussell/spring-kafka that referenced this issue Jun 27, 2022
With default implementation (suspend thread) and container pausing/resuming implementation.

init commit

adding default impl

changes

add Apache licence

pr fix

style fixes
added ListenerContainerPauseService
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Jun 27, 2022
garyrussell pushed a commit that referenced this issue Jun 27, 2022
With default implementation (suspend thread) and container pausing/resuming implementation.

init commit

adding default impl

changes

add Apache licence

pr fix

style fixes
added ListenerContainerPauseService
garyrussell added a commit that referenced this issue Jun 27, 2022
garyrussell added a commit that referenced this issue Jun 27, 2022
garyrussell added a commit that referenced this issue Jun 27, 2022
garyrussell added a commit that referenced this issue Jun 27, 2022
garyrussell added a commit that referenced this issue Jul 11, 2022
MLC can be null.

Other Sonar fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants