Skip to content

Polish KafkaHeaders Constants #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue May 5, 2022 · 0 comments
Closed

Polish KafkaHeaders Constants #2260

garyrussell opened this issue May 5, 2022 · 0 comments
Labels
type: task
Milestone
2.9.0-RC1

Comments

@garyrussell
Copy link
Contributor

Move to less verbose constant names (values must stay the same).

MESSAGE_KEY -> KEY
PARTITION_ID -> PARTITION

(and RECEIVED_* versions of those).

Deprecate the old ones and remove in 3.0.
@garyrussell garyrussell added this to the 2.9.0-M2 milestone May 5, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue May 5, 2022
@garyrussell
spring-projectsGH-2260: Reduce Header Constant Verbosity
5f11dc0 
Resolves spring-projects#2260

**cherry-pick to main, removing 4 deprecated constants**
@garyrussell garyrussell mentioned this issue May 5, 2022
Merged
artembilan pushed a commit that referenced this issue May 5, 2022
@garyrussell @artembilan
GH-2260: Reduce Header Constant Verbosity
80243ed 
Resolves #2260

**cherry-pick to main, removing 4 deprecated constants**
@garyrussell garyrussell modified the milestones: 2.9.0-M2, 2.9.0-RC1 Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task
Projects
None yet
Milestone
2.9.0-RC1
Development

No branches or pull requests
1 participant
@garyrussell