Skip to content

Introduce RetryTopicConfigurationSupport #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomazfernandes opened this issue Apr 10, 2022 · 0 comments
Closed

Introduce RetryTopicConfigurationSupport #2226

tomazfernandes opened this issue Apr 10, 2022 · 0 comments
Assignees
Milestone

Comments

@tomazfernandes
Copy link
Contributor

Improve the retry topic feature's component configuration by introducing a RetryTopicConfigurationSupport, based on WebMvcConfigurationSupport, as suggested by @artembilan.

tomazfernandes added a commit to tomazfernandes/spring-kafka that referenced this issue Apr 10, 2022
Resolves spring-projects#2226

Add RetryTopicConfigurationSupport
Add @EnableRetryTopic
Add KafkaBackOffManagerConfigurationSupport
@garyrussell garyrussell added this to the 2.9.0-RC1 milestone Apr 11, 2022
tomazfernandes added a commit to tomazfernandes/spring-kafka that referenced this issue Apr 12, 2022
Resolves spring-projects#2226

Add RetryTopicConfigurationSupport
Add @EnableRetryTopic
Add KafkaBackOffManagerConfigurationSupport
tomazfernandes added a commit to tomazfernandes/spring-kafka that referenced this issue Apr 12, 2022
Resolves spring-projects#2226

Add RetryTopicConfigurationSupport
Add @EnableRetryTopic
Add KafkaBackOffManagerConfigurationSupport
tomazfernandes added a commit to tomazfernandes/spring-kafka that referenced this issue Apr 15, 2022
Resolves spring-projects#2226

Add RetryTopicConfigurationSupport
Add @EnableRetryTopic
Add KafkaBackOffManagerConfigurationSupport
garyrussell pushed a commit to garyrussell/spring-kafka that referenced this issue Apr 27, 2022
Resolves spring-projects#2226

Add RetryTopicConfigurationSupport
Add @EnableRetryTopic
Add KafkaBackOffManagerConfigurationSupport
garyrussell pushed a commit that referenced this issue Apr 27, 2022
Resolves #2226

Add RetryTopicConfigurationSupport
Add @EnableRetryTopic
Add KafkaBackOffManagerConfigurationSupport

Address code review comments

* Change deprecated constants for strings
* Remove deprecation suppressions
* Remove ApplicationContext and BeanFactory from constructors
* Change TaskExecutor shutdown logic to DisposableBean

Remove KafkaBackOffManagerConfigurationSupport

Move Task Executor logic to Timing Adjuster

Add unit tests

Enable managing fatal exceptions with a List

Create defaultFatalExceptionsList method in `ExceptionClassifier`

Change RetryTopicConfigurationSupport logic to provide a list instead of a configurer for non-blocking retries

Make provided TaskExecutor a bean

Add KafkaBackOffManagerConfigurer to RetryTopicConfigurationSupport

Add documentation

Review javadocs

Few other adjustments

Use JavaUtils instead of if statements

Add acceptIfInstanceOf to JavaUtils

Address PR review comments

Restore `ThreadPoolTaskExecutor` bean

Polishing per review comments.
garyrussell added a commit that referenced this issue Apr 27, 2022
garyrussell added a commit that referenced this issue Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants