Skip to content

Add Utility to Log ProducerRecord Metadata Only #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Feb 23, 2022 · 2 comments
Closed

Add Utility to Log ProducerRecord Metadata Only #2132

garyrussell opened this issue Feb 23, 2022 · 2 comments
Labels
backport 2.7.x (obsolete) backport 2.8.x (obsolete) type: enhancement
Milestone
3.0.0-M3

Comments

@garyrussell
Copy link
Contributor

e.g.

spring-kafka/spring-kafka/src/main/java/org/springframework/kafka/requestreply/ReplyingKafkaTemplate.java

Line 381 in 38ed222

this.logger.debug(() -> "Sending: " + record + WITH_CORRELATION_ID + correlationId);

spring-kafka/spring-kafka/src/main/java/org/springframework/kafka/requestreply/ReplyingKafkaTemplate.java

Line 399 in 38ed222

this.logger.warn(() -> "Reply timed out for: " + record + WITH_CORRELATION_ID + correlationId);

Need an option to just log the metadata.

https://stackoverflow.com/questions/71244102/spring-kafka-replyingkafkatemplate-logs-full-details-instead-of-metadata-only-wh
@garyrussell garyrussell added this to the 3.0.0-M3 milestone Feb 23, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Feb 23, 2022
@garyrussell
spring-projectsGH-2132: Producer Record Log Formatting
1dba6f3 
Resolves spring-projects#2132

Allow the user to provide a function for formatting producer records.

Also move consumer record formatting to `KafkaUtils` will deprecate
`ListenerUtils` versions later.
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Feb 23, 2022
@garyrussell
spring-projectsGH-2132: Producer Record Log Formatting
b7b630b 
Partial solution for  spring-projects#2132

Allow the user to provide a function for formatting producer records.

Also move consumer record formatting to `KafkaUtils` will deprecate
`ListenerUtils` versions later.

There will be more polising in this area for 3.0 only (separate PR).

**cherry-pick to 2.8.x, 2.7.x**
@garyrussell garyrussell mentioned this issue Feb 23, 2022
Merged
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Mar 7, 2022
@garyrussell
spring-projectsGH-2132: Producer Record Log Formatting
02c6e65 
Partial solution for  spring-projects#2132

Allow the user to provide a function for formatting producer records.

Also move consumer record formatting to `KafkaUtils` will deprecate
`ListenerUtils` versions later.

There will be more polising in this area for 3.0 only (separate PR).

**cherry-pick to 2.8.x, 2.7.x**
artembilan pushed a commit that referenced this issue Mar 7, 2022
@garyrussell @artembilan
GH-2132: Producer Record Log Formatting
891664b 
Partial solution for  #2132

Allow the user to provide a function for formatting producer records.

Also move consumer record formatting to `KafkaUtils` will deprecate
`ListenerUtils` versions later.

There will be more polising in this area for 3.0 only (separate PR).

**cherry-pick to 2.8.x, 2.7.x**
artembilan pushed a commit that referenced this issue Mar 7, 2022
@garyrussell @artembilan
GH-2132: Producer Record Log Formatting
f6e4a7d 
Partial solution for  #2132

Allow the user to provide a function for formatting producer records.

Also move consumer record formatting to `KafkaUtils` will deprecate
`ListenerUtils` versions later.

There will be more polising in this area for 3.0 only (separate PR).

**cherry-pick to 2.8.x, 2.7.x**
artembilan pushed a commit that referenced this issue Mar 7, 2022
@garyrussell @artembilan
GH-2132: Producer Record Log Formatting
297f52d 
Partial solution for  #2132

Allow the user to provide a function for formatting producer records.

Also move consumer record formatting to `KafkaUtils` will deprecate
`ListenerUtils` versions later.

There will be more polising in this area for 3.0 only (separate PR).

**cherry-pick to 2.8.x, 2.7.x**
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Mar 7, 2022
@garyrussell
spring-projectsGH-2132: Deprecate ListenerUtils.recordToString
35ca842 
Resolves spring-projects#2133

Apply to 2.8.x, and 2.7.x.

In 3.0 they will be removed and `KafkaUtils` called directly instead.
artembilan pushed a commit that referenced this issue Mar 7, 2022
@garyrussell @artembilan
GH-2132: Deprecate ListenerUtils.recordToString
8ec7ed0 
Resolves #2133

Apply to 2.8.x, and 2.7.x.

In 3.0 they will be removed and `KafkaUtils` called directly instead.
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Mar 8, 2022
@garyrussell
Partial Revert "spring-projectsGH-2132: Producer Record Log Fo..."
9ea34ef 
Resolves spring-projects#2132

This reverts commit 297f52d.

Just the consumer record part.
@garyrussell garyrussell mentioned this issue Mar 8, 2022
Merged
artembilan pushed a commit that referenced this issue Mar 8, 2022
@garyrussell @artembilan
Partial Revert "GH-2132: Producer Record Log Fo..."
bd3d43f 
Resolves #2132

This reverts commit 297f52d.

Just the consumer record part.
@garyrussell
Copy link
Contributor Author

Closed by 891664b and back-ported to 2.8.x, 2.7.x

@artembilan
Copy link
Member

Closed according the previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport 2.7.x (obsolete) backport 2.8.x (obsolete) type: enhancement
Projects
None yet
Milestone
3.0.0-M3
Development

No branches or pull requests
2 participants
@garyrussell @artembilan