LoggingProducerListener.onError() causes OutOfMemory exceptions for large messages

[krocodl]

For spring-kafka 2.5.2.RELEASE

The problem code fragment:

.append(" and payload='") .append(toDisplayString(ObjectUtils.nullSafeToString(record.value()), this.maxContentLogged))

For example, it the service tries to handle 20Mb message and the parameter "spring.cloud.stream.kafka.binder.configuration.max.request.size" is not increased accordingly, we expect to receive an exception about the "max.request.size" value.

But instead of this, ObjectUtils.nullSafeToString(record.value()) attempts to transform byte[] inside the String, where each byte is represented by about 5 bytes - something like ", 123".
As a result, we receive OOM, where the StringJoiner object occupies about half of the memory.

So, it is necessary to pass the "this.maxContentLogged" parameter inside the function "ObjectUtils.nullSafeToString" too, in order to prevent dumping the full byte array.

[krocodl]

BTW, this pattern is widely copied in Kafka-related projects. For example, we can see completely the same in the KafkaMessageChannelBinder.DlqSender.sendToDlq() and have completely the same OOM error with large messages.

[krocodl]

A temporary workaround:
@Bean public ProducerListener<Object, Object> fixedKafkaProducerListener() { return new FixedLoggingProducerListener<>(); }

This listener will be already used by createProducerMessageHandler:387, KafkaMessageChannelBinder
but NOT by
getErrorMessageHandler:1058, KafkaMessageChannelBinder