Fix exception message for method doPoll in JpaExecutor
#9997
Conversation
There was a problem hiding this comment.
Sorry, I cannot accept those @ParameterizedTest changes.
Doesn't look like it makes our life easier: so much new if...else logic to satisfy.
I would prefer to have duplication in different test method, but as linear as possible, then some extra logic to meet @ParameterizedTest set requirements.
This also does not make it more flexible. If we add a new scenario, and would try to cover it in the generic @ParameterizedTest method, that may lead to failure for existing scenarios.
We may think that there is a bug in the main code, but it could simply be a problem of the test method. Just because it is too complex to deal with all the @ParameterizedTest variants.
Just my opinion where I would prefer to not do such a refactoring.
Thanks
spring-integration-jpa/src/main/java/org/springframework/integration/jpa/core/JpaExecutor.java
Show resolved
Hide resolved
Signed-off-by: Jiandong Ma <[email protected]>
|
Thank you, actually I also have this feeling, removed |
mjd507
changed the title
doPoll in JpaExecutor
Signed-off-by: Jiandong Ma <[email protected]> [[email protected] Improve commit message] Fixes: #9997 The `nativeQuery` has to be mention in the possible required options to configure. (cherry picked from commit 119209d)
Signed-off-by: Jiandong Ma <[email protected]> [[email protected] Improve commit message] Fixes: #9997 The `nativeQuery` has to be mention in the possible required options to configure. (cherry picked from commit 119209d)
using
@ParameterizedTestto aggregate similar unit test cases