Skip to content

GH-8681: Websocket: Expose send buffer overflow strategy in XML config #8682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

ColoredCarrot
Copy link
Contributor

Implement #8681: Add an XML configuration element for the send buffer overflow strategy (Client- and ServerWebSocketContainer)

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Can you now, please, consider to add a new section in the whats-new.adoc like:

[[x6.2-websockets]]
=== WebSockets Changes

And mention this new option with the link in the end to the web-sockets.adoc.

Thank you!

@ColoredCarrot
Copy link
Contributor Author

Sure thing, though I won't be able to get to it for a day or two

@artembilan
Copy link
Member

That's OK, no rush: we have like a month until next milestone.

Thank you for consider the fix!

@artembilan artembilan merged commit bd013e0 into spring-projects:main Jul 24, 2023
@artembilan
Copy link
Member

@ColoredCarrot ,

Thank you for contribution!

If you are looking forward for more of them, feel free to pick any opened issue or consider to add Java DSL for this WebSocket module.

@ColoredCarrot
Copy link
Contributor Author

Thanks @artembilan :)
I'm doing my bachelor's thesis at the moment, so not too much free time. But I've really enjoyed contributing, so I'll definitely look for more when I can!

@ColoredCarrot ColoredCarrot deleted the GH-8681 branch July 24, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants